Bug: Non ISO-8859-1 filenames cannot be downloaded with AWS

[sngular-rplaza]

Hi there.

I have an issue using quotation marks in filenames. When i use it, i have this error produced by download stage in Gokapi. This is the file in Gokapi dashboard, pointing to S3 bucket as backend in my cloudconfig.yml:

And this is the error when i download it:

I don't have much experience using Go, so my knowledge is very limited, but i saw that don't have any UTF-8 support for filenames. I don't really know how to write it in code, but i think it could be something like this example inside download procedure:

Content-Disposition: attachment; filename="fallback.pdf"; filename*=UTF-8''Informe_%C3%A1rea.pdf

Thank you.

[Forceu]

Thanks a lot, I will look into it!

[sngular-rplaza]

Hi again.

To give you some context about it, i'm using the docker image v2.0.1 in a kubernetes cluster, just in case you have any other procedure for docker or something like that.

Thanks.

[sngular-rplaza]

One of my colleague change this to test it in local and it worked, if it helps:

Inside internal -> filesystem -> s3filesystem -> Aws.go, importing net/url package:

func getPresignedUrl(file models.File, forceDownload bool) (string, error) {
	sess := createSession()
	s3svc := s3.New(sess)

	dispositionType := "inline"
	if forceDownload {
		dispositionType = "Attachment"
	}
	// Use RFC 6266 format to support UTF-8 filenames and avoid encoding errors.
	contentDisposition := fmt.Sprintf("%s; filename*=UTF-8''%s", dispositionType, url.PathEscape(file.Name))

	req, _ := s3svc.GetObjectRequest(&s3.GetObjectInput{
		Bucket:                     aws.String(file.AwsBucket),
		Key:                        aws.String(file.SHA1),
		ResponseContentDisposition: aws.String(contentDisposition),
		ResponseCacheControl:       aws.String("no-store"),
		ResponseContentType:        aws.String(file.ContentType),
	})

	return req.Presign(15 * time.Second)
}

Thanks.

[Forceu]

That sounds great, thank you very much for fixing the problem! I will test it tomorrow and then merge the fix :)

[Forceu]

Fixed in dd5a0b2, thanks.

Interestingly enough I was unable to reproduce the problem. Either it is because I am using Linux with UTF-8 being the default charset or because I am using Backblaze instead of AWS for testing.