[Enhancement] Update `Dockerfile` for the new CLI tool

[zwimer]

For the brand new #280 it seems that the latest docker container latest-dev does not contain a built version of the new CLI tool.

If this tool is included in the docker container, users on the same system can upload files via something similar to:

alias gokapi-cli='docker exec gokapi -it /bin/gokapi-cli

[zwimer]

Thanks for implementing #280 ! This was the big hurdle preventing me from making the transition to gokapi. :)

[Forceu]

Yes, it is not included in the Docker build, as it has to be manually compiled. I am actually currently working on a Docker image for the tool. The only problem is that that way you either have to mount the folder containing the file to upload or that you pipe the file - but that way the filename would not be present....
If you want to, I can however upload a binary here for you to test, just let me know what OS you are using

[zwimer]

As you imply, the ideal solution is an easily installable stand-alone tool; preferably available via a package manager (as it makes keeping up to date trivial).

A stand-alone download would be great for many users and is a great idea, though personally I'd prefer the docker container as it makes keeping up to date effortless (via something like watchtower). That is, I don't want to have to periodically check github to see if a new release is out to monitor ensure no security-related bugs stay present on my system.

With docker, although not ideal, one could do something like make a small wrapper script (using GNU realpath):

#!/bin/bash -eu

ARGS=()
for i; do
	if [[ "$i" =~ ^(.\/|\/).+$ ]]; then ARGS+=("/fs$(realpath -s "$i")")
	else ARGS+=("$i"); fi
done

exec docker run --rm \
	--user "$(id -u):$(id -g)" \
	-v /:/fs \
	-it gokapi-cli \
	"${ARGS[@]}"

Although also not ideal, something like this should be a good-enough wrapper for most non-SELinux cases.

[zwimer]

While I know it's pretty trivial to setup a package for homebrew that auto-updates from github's releases page, I'm not sure how difficult it would be to handle apt or dnf (as for those you'd also need to either get your package in a repo or make one yourself). Of course, these would be the ideal, but given this feature was just released today I am under no delusions that such a thing ought to be expected any time soon. As such I'm believe a dockerized tool is sufficient for now.

[zwimer]

just let me know what OS you are using

@Forceu Fedora and macOS are my preferred.

[Forceu]

Thanks for the input! I actually settled for now on having the tool check if it is running in Docker, and if it is to check if there is a single file in the folder /upload/. That way you simply have to mount the file to appear in the /upload/ folder (or mount any folder and specify the file with the -f argument.

It is not ideal, but maybe I or someone else comes up with a better solution at some point. I like your idea with the wrapper script, but that would also mean that there has to be a second script (which is platform-dependent), which I would like to avoid.

Feel free to try the attached binaries, I will probably publish the docker image tonight.

gokapi-cli-darwin_amd64.zip
gokapi-cli-darwin_arm64.zip
gokapi-cli-linux_amd64.zip

[zwimer]

To clarify, I was explaining why I think keeping the gokapi-cli docker image was a good idea, as that wrapper script is likely what I'll personally use until (hopefully sometime in the future) the tool is available via a package manager.

With that said, I don't think a 'best effort' script that supports the most popular OS's is a terrible idea; after all the script can just spit back unsupported OS for more obscure distros like DragonflyBSD and such (sort of like it is common to only support brew, apt, dnf, and the maybe paccman package managers.

@Forceu Another option you could support, if you desired, is having the tool check for updates itself. This is not an uncommon approach for tools that are not managed by package managers. I.e. on invocation of gokapi-cli: 'if (last update_check() > 1 week ago) then if current_version < "$(curl -s https://api.github.com/repos/Forceu/Gokapi/releases/latest | jq -r '.tag_name[1:]')"; then warn_user("using outdated_version")` or something like that.

In any case, I'll try to test the CLI tool this weekend after I re-setup my gokapi instance and after the docker images are published.

[Forceu]

I don't think I will include a version check, but I will keep it in mind. The docker image is up, you can find the documentation here:

https://gokapi.readthedocs.io/en/latest/advanced.html#cli-tool

If you experience any problems with me or have feedback, let me know :)

[zwimer]

@Forceu I'm not sure if you prefer I open up new issues for bugs I find in the CLI or just message you here. Feel free to tell me your preference. In any case, the first bug I found was when testing the CLI against an older version of the server. I got:

Testing connection...
ERROR: Gokapi version must be at least 2.1.0
Your version is
/app #

The bug is minor, but you'll notice the "Your version is" is missing the version. For now though I'll open a few issues.