Ability to pass amd dependencies to a define part. #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support for passing dependencies added yet.
| @@ -76,3 +76,15 @@ function compileNamespaceStep(name) { | |||
| name = camelCase(name); | |||
| return 'g=(g.' + name + '||(g.' + name + ' = {}))'; | |||
| } | |||
|
|
|||
| function getDependencies(dependencies) { | |||
There was a problem hiding this comment.
@sprilukin Isn't this function essentially doing JSON.stringify(), without the brackets?
| @@ -76,3 +78,7 @@ function compileNamespaceStep(name) { | |||
| name = camelCase(name); | |||
| return 'g=(g.' + name + '||(g.' + name + ' = {}))'; | |||
| } | |||
|
|
|||
| function getDependencies(dependencies) { | |||
| return dependencies ? JSON.stringify(dependencies).replace(/^\[/g, "").replace(/]$/g, "") : ""; | |||
There was a problem hiding this comment.
@sprilukin You could just ensure that dependencies is an array, keep the brackets, and replace [deps()] with deps() in template.js.
|
@sprilukin can you document the new option? |
|
@jazzzz, done could you please check whether it's enough good option description? |
|
@jazzzz including cmd line support for this feature will introduce dependency on some cmd line helper library, so it will require more work... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is what is basically want to see for issue #32
No cmd line support for passing dependencies added yet.