Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Offset Implementation & Handling #300

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
+158 −6
Open

feat: Add Offset Implementation & Handling #300

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
42d4210
initial attempt at adding offset
tripflex Jul 18, 2023
bd262ea
add pg-typed limit
tripflex Jul 18, 2023
1d691fa
add mysql-typed
tripflex Jul 18, 2023
74d0074
chore: prettier
tripflex Jul 18, 2023
4b35c66
return OrderedSelectQueryWithOffset
tripflex Jul 18, 2023
4074179
add possible failing pg-typed test
tripflex Jul 18, 2023
5e55d85
add OrderedSelectQueryWithOffset
tripflex Jul 18, 2023
b42e5b3
tests
tripflex Jul 18, 2023
381e96d
fix: cleanup interfaces and add error check for mock-db-typed
ForbesLindesay Aug 11, 2023
2545fd9
fix: cleanup interfaces and add error check for mysql-typed
ForbesLindesay Aug 11, 2023
168ec7b
fix: cleanup interfaces and add error check for pg-typed
ForbesLindesay Aug 11, 2023
e8916ce
docs: document offset for mysql-typed
ForbesLindesay Aug 11, 2023
729c2a2
docs: document offset for pg-typed
ForbesLindesay Aug 11, 2023
901f2ea
fix: return type for offset implementation in pg-typed
ForbesLindesay Aug 11, 2023
a582671
fix: return type for offset implementation in mysql-typed
ForbesLindesay Aug 11, 2023
f2ce0e6
fix: return type for offset implementation in mock-db-typed
ForbesLindesay Aug 11, 2023
679055f
fix: return type of offset does not need to be a Promise
ForbesLindesay Aug 11, 2023
7b3ec65
fix: return type of offset does not need to be a Promise
ForbesLindesay Aug 11, 2023
d0fe99d
fix: run prettier:write
ForbesLindesay Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add possible failing pg-typed test
  • Loading branch information
@tripflex
tripflex committed Jul 18, 2023
commit 4074179d14f057525e12a6f10c478868f8e56eb5
11 changes: 11 additions & 0 deletions packages/pg-typed/src/__tests__/index.test.pg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,17 @@ test('create users', async () => {
]
`);

const photoRecordsOffset = await photos(db)
.find({owner_user_id: forbes.id})
.orderByAsc('cdn_url')
.offset(1)
.limit(1);
expect(photoRecordsOffset.map((p) => p.cdn_url)).toMatchInlineSnapshot(`
Array [
"http://example.com/3",
]
`);

const photoRecordsDesc = await photos(db)
.find({owner_user_id: forbes.id})
.orderByDesc('cdn_url')
Expand Down