Open
Conversation
tackc
requested changes
Nov 26, 2023
Collaborator
tackc
left a comment
tackc
left a comment
There was a problem hiding this comment.
Once the LoginPage h1 is switched back, it should be good to go!
| </Col> | ||
| <Col sm={6}> | ||
| <h1 className={styles.title}>BANANA PORTAL</h1> | ||
| <h1 className={styles.title}>BRENDAN PORTAL 3</h1> |
Collaborator
There was a problem hiding this comment.
Once you switch this back to BANANA PORTAL, you can go ahead and merge it!
Collaborator
There was a problem hiding this comment.
@brendobrendo @tackc yep I agree, looks good 🚀
renburnett
requested changes
Jan 6, 2024
| </Col> | ||
| <Col sm={6}> | ||
| <h1 className={styles.title}>BANANA PORTAL</h1> | ||
| <h1 className={styles.title}>BRENDAN PORTAL 3</h1> |
Collaborator
There was a problem hiding this comment.
@brendobrendo @tackc yep I agree, looks good 🚀
Collaborator
|
Looks good to me @brendobrendo! Just wondering since we are not using artifact files like the Docker image, what's your idea about building code on GitHub and just copying the output to the VM? For instance, rewriting step Build code on VM to GitHub action and copy output to Vm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Trello Card
What kind of change does this PR introduce? (bug fix, feature, docs update, ...)
Creates a CI/CD Pipeline using GitHub Actions. It only deploys changes when a PR is merged into the master branch. I've updated the repo settings to
TODO:
Implement tests. Potentially re-build it using Jenkins.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Not that I know of.