This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
DocumentUtil static #2232
Merged
DocumentUtil static #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two non-static methods are kept for temporary compatibility
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
DocumentUtilto be entirely a static utility class. The reason that this was originally non-static was due to the use of its_transparentColorPatternfield, which was stored to cache the regex. However, this can just as easily be assigned to the class itself for the same functionality. This simplifies the class API quite a bit and will no longer require instantiating and sharing instances across various classes.