This repository has been archived by the owner on Feb 25, 2023. It is now read-only.
String frequency support #1989
Merged
String frequency support #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toasted-nutbread
added a commit
that referenced
this pull request
Oct 15, 2021
* Restore support for string frequency values
* Add support for {value, displayValue} frequencies
* Update test data
* Improve number parsing of string frequencies
* Improve reading detection
* Expose a displayValue property for frequency information
* Update docs
* Expose displayValue to Anki note data
* Fix translator
* Update display generation
* Update test data
* Update counts
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change restores support for importing and using* string frequencies which was previously removed in #1943.
* If the string does not contain a number that can be parsed, the numeric frequency value will be 0.
Additionally, dictionary authors can now specify frequency values in the form
{"value": (number), "displayValue": (string)}, which allows for providing an explicit numeric value to go with the string value that is presented to the user. See the updatedfrequencydefinitions in:Examples:
Resolves #1984.