fix: send token adapter fees #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d778ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
palace22
force-pushed
the
fix/send-token-adapter-fees
branch
from
ed4db54
to
2428d25
Compare
gidonkatten
requested changes
Sep 18, 2024
| // get return adapter fee | ||
| return await hubBridgeRouter.read.getSendFee([returnMessage]); | ||
| // get return adapter fee increased by 1% | ||
| return increaseByPercent(await hubBridgeRouter.read.getSendFee([returnMessage]), 0.01); |
There was a problem hiding this comment.
define constant RECEIVER_VALUE_SLIPPAGE
gidonkatten
approved these changes
Sep 18, 2024
gidonkatten
pushed a commit
that referenced
this pull request
Sep 20, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @folks-finance/xchain-sdk@0.0.28 ### Patch Changes - [#151](#151) [`965b38e`](965b38e) Thanks [@gidonkatten](https://github.com/gidonkatten)! - Fixed BTCb ava spoke token - [#151](#151) [`965b38e`](965b38e) Thanks [@gidonkatten](https://github.com/gidonkatten)! - deploy mainnet - [#159](#159) [`8854ef7`](8854ef7) Thanks [@gidonkatten](https://github.com/gidonkatten)! - add addresses to fee data - [#151](#151) [`965b38e`](965b38e) Thanks [@gidonkatten](https://github.com/gidonkatten)! - fix precision of price formulae - [#154](#154) [`32b44f5`](32b44f5) Thanks [@palace22](https://github.com/palace22)! - increased send token adapter fees by 1% Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated send token adapter fees by 1%