Skip to content

Add option to persist values by re-applying them - #371

Open
ReimuNotMoe wants to merge 1 commit into
FlyGoat:masterfrom
ReimuNotMoe:master
Open

Add option to persist values by re-applying them#371
ReimuNotMoe wants to merge 1 commit into
FlyGoat:masterfrom
ReimuNotMoe:master

Conversation

@ReimuNotMoe

Copy link
Copy Markdown

It solves this problem. Apparently this is the only way if the firmware is interfering.

@FlyGoat

FlyGoat commented Sep 11, 2025

Copy link
Copy Markdown
Owner

Hi @ReimuNotMoe,

Many thanks for your contribution. My personal preference would be to let user perform persist operation via external scripts, as what we've done in https://github.com/FlyGoat/RyzenAdj/blob/master/examples/readjust.py.

I'm open to merge it in case others find it's useful, for now I'll leave this PR open.

Thanks

@ReimuNotMoe

ReimuNotMoe commented Sep 13, 2025

Copy link
Copy Markdown
Author

In my opinion this is more efficient because launching an executable is a rather expensive operation. If you try to re-apply the values at a fast rate, let's say 50Hz, the performance impact will be visible. The command line will be parsed repeatedly, and the device files will be opened repeatedly. My laptop's firmware is pretty stubborn and will reset the values in less than 1 second during active use.

Still, I wouldn't ask for this to be merged. You decide.

Edit: I didn't look at the script you mentioned carefully. Nvm I guess.

@Falcosc

Falcosc commented Sep 14, 2025

Copy link
Copy Markdown
Collaborator

Yes, over CLI it would be wasteful, you have to go the library route. Sadly, many windows integrations actually implement the CLI instead of skipping initialization with the library.

Your use case was the reason for implementing the limits table, despite not being the purpose of ryzenAdj. We did stretch the scope of the project to get the unexpected limits change use case more efficiently implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants