Add site and site_slug labels to device services #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Hello,
when developing an internal Service Discovery framework I found out that Netbox devices do not necessarily have the Site label present. When digging I found out that the condition applies only to devices without Cluster set. I've made this PR to prioritize locally configured Site of the device object, instead of Rack or Cluster. Given how loose the constraints in Netbox database are, I might have missed something. Let me know please!
Issue ticket number and link
None.
Checklist before requesting a review