PR for issue #398. #406
Merged
PR for issue #398. #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToucheSir
reviewed
Feb 7, 2024
Comment on lines
+69
to
+72
| Xtext = [collect(t) for t in chunk(text, args.batchsz)] | ||
| Ytext = [collect(t) for t in chunk(text[2:end], args.batchsz)] | ||
| Xs = partition(batchseq(Xtext, stop), args.seqlen) | ||
| Ys = partition(batchseq(Ytext, stop), args.seqlen) |
Member
There was a problem hiding this comment.
Can you explain the reasoning behind this change? Generally, I would not expect collect to be required here.
Contributor
Author
There was a problem hiding this comment.
The problem seems to be that chunk(text, args.batchsz) creates an array of SubStrings. batchseq calls ndims on this array. However, ndims does not seem to be defined for SubStrings. The Strings are converted into an array of characters (for which ndims is available).
Without the change you get:
ERROR: LoadError: MethodError: no method matching ndims(::SubString{String})
Member
There was a problem hiding this comment.
I see. We should fix batchseq to work with strings, but that can happen separately. Thanks for elaborating.
Contributor
Author
|
Thank you, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #398.
char-rnn.jlaccording to description/sugesstion in issue text.