Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial redirects #163

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

Saransh-cpp
Copy link
Member

Following up on #156

PR Checklist

  • Tests are added
  • Documentation, if applicable

@ToucheSir
Copy link
Member

I just checked all the links on http://fluxml.ai/tutorials/ and none of them are broken. Is there a reason for this specific change?

@Saransh-cpp
Copy link
Member Author

The link for each tutorial post went stale - https://fluxml.ai/tutorialposts/2020-09-15-deep-learning-flux/

Copy link
Member Author

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep both meta and external in each file?

@@ -2,7 +2,6 @@
title = "Generative Adversarial Networks"
published = "14 October 2021"
author = "Ralph Kube"
external = "http://fluxml.ai/Flux.jl/stable/tutorials/2021-10-14-vanilla-gan/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

external makes the link in /tutorials work (attaches an external link to the bullets)

Comment on lines +7 to +9
~~~
<meta http-equiv="refresh" content="0; url='http://fluxml.ai/Flux.jl/stable/tutorials/2021-10-08-dcgan-mnist/'"/>
~~~
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually makes each /tutorialpost link redirect to another link.

@ToucheSir
Copy link
Member

Yes, both would be good then.

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ToucheSir ToucheSir merged commit 19dc106 into FluxML:main Nov 10, 2023
1 check passed
@Saransh-cpp Saransh-cpp deleted the redirect-tutorials branch November 11, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants