-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tutorial redirects #163
Conversation
I just checked all the links on http://fluxml.ai/tutorials/ and none of them are broken. Is there a reason for this specific change? |
The link for each tutorial post went stale - https://fluxml.ai/tutorialposts/2020-09-15-deep-learning-flux/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep both meta
and external
in each file?
@@ -2,7 +2,6 @@ | |||
title = "Generative Adversarial Networks" | |||
published = "14 October 2021" | |||
author = "Ralph Kube" | |||
external = "http://fluxml.ai/Flux.jl/stable/tutorials/2021-10-14-vanilla-gan/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
external
makes the link in /tutorials
work (attaches an external link to the bullets)
~~~ | ||
<meta http-equiv="refresh" content="0; url='http://fluxml.ai/Flux.jl/stable/tutorials/2021-10-08-dcgan-mnist/'"/> | ||
~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually makes each /tutorialpost
link redirect to another link.
Yes, both would be good then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Following up on #156
PR Checklist