move NNlib rules out of Zygote #824
Conversation
simeonschaub
changed the title
simeonschaub
force-pushed
the
sds/move_nnlib
branch
from
45dc941
to
85c97e8
Compare
|
As discussed in FluxML/NNlib.jl#242 (comment), I have now tagged this as a breaking release, since that seemed more straightforward. I can change that though, if so desired. Should be ready to go from my side. |
|
@simeonschaub merge? |
|
Sure! |
|
bors r+ |
824: move NNlib rules out of Zygote r=CarloLucibello a=simeonschaub Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions. Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
|
Build failed: |
|
Sorry, I missed one |
|
bors r+ |
824: move NNlib rules out of Zygote r=CarloLucibello a=simeonschaub Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions. Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
|
Timed out. |
|
bors r+ |
824: move NNlib rules out of Zygote r=CarloLucibello a=simeonschaub Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions. Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
|
Timed out. |
|
what's going on with bors? |
|
Is bors fixed now or can we proceed without it? |
simeonschaub
force-pushed
the
sds/move_nnlib
branch
from
a03cada
to
fd60d1d
Compare
|
Just so this doesn't get missed: We probably want to wait for #842 to be merged as well until we release this. (#848 (comment)) |
|
@simeonschaub I'm a bit confused by this PR -- what aspect of it is breaking? |
|
See the discussion in FluxML/NNlib.jl#242. We need to ensure that nobody is using a Zygote version with this PR together with an older NNlib version. Since those packages now don't directly depend on each other, tagging both as breaking and requiring packages with a dependency to explicitly bump both versions simultaneously seemed like the most straightforward solution. |
Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions.