Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move NNlib rules out of Zygote #824

Merged
merged 4 commits into from
Dec 8, 2020

Conversation

simeonschaub
Copy link
Member

Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions.

@simeonschaub simeonschaub changed the title RFC: move NNlib rules out of Zygote move NNlib rules out of Zygote Nov 21, 2020
@simeonschaub simeonschaub marked this pull request as ready for review November 21, 2020 19:11
@simeonschaub
Copy link
Member Author

As discussed in FluxML/NNlib.jl#242 (comment), I have now tagged this as a breaking release, since that seemed more straightforward. I can change that though, if so desired. Should be ready to go from my side.

@CarloLucibello
Copy link
Member

@simeonschaub merge?

@simeonschaub
Copy link
Member Author

Sure!

@CarloLucibello
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Nov 27, 2020
824: move NNlib rules out of Zygote r=CarloLucibello a=simeonschaub

Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions.

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 27, 2020

Build failed:

@simeonschaub
Copy link
Member Author

Sorry, I missed one using NNlib statement, but that should be fixed now.

@CarloLucibello
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Nov 27, 2020
824: move NNlib rules out of Zygote r=CarloLucibello a=simeonschaub

Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions.

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 27, 2020

Timed out.

@CarloLucibello
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Nov 27, 2020
824: move NNlib rules out of Zygote r=CarloLucibello a=simeonschaub

Partner to FluxML/NNlib.jl#242. I talked a bit about how to go about releasing this there, would appreciate any feedback and suggestions.

Co-authored-by: Simeon Schaub <simeondavidschaub99@gmail.com>
@bors
Copy link
Contributor

bors bot commented Nov 27, 2020

Timed out.

@CarloLucibello
Copy link
Member

what's going on with bors?

@simeonschaub
Copy link
Member Author

Is bors fixed now or can we proceed without it?

@simeonschaub
Copy link
Member Author

simeonschaub commented Dec 8, 2020

Just so this doesn't get missed: We probably want to wait for #842 to be merged as well until we release this. (#848 (comment))

@CarloLucibello CarloLucibello added this to the v0.6 milestone Dec 8, 2020
@CarloLucibello CarloLucibello merged commit 5b24c3a into FluxML:master Dec 8, 2020
@simeonschaub simeonschaub deleted the sds/move_nnlib branch December 8, 2020 17:37
@willtebbutt willtebbutt mentioned this pull request Dec 8, 2020
@willtebbutt
Copy link
Member

@simeonschaub I'm a bit confused by this PR -- what aspect of it is breaking?

@simeonschaub
Copy link
Member Author

See the discussion in FluxML/NNlib.jl#242. We need to ensure that nobody is using a Zygote version with this PR together with an older NNlib version. Since those packages now don't directly depend on each other, tagging both as breaking and requiring packages with a dependency to explicitly bump both versions simultaneously seemed like the most straightforward solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants