Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ChainRules AbstractZero types #786

Merged
merged 63 commits into from
Oct 9, 2020
Merged

support ChainRules AbstractZero types #786

merged 63 commits into from
Oct 9, 2020

Commits on Sep 9, 2020

  1. test suite

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1476352 View commit details
    Browse the repository at this point in the history

  2. minimal changes with only few broken bits

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c0ef65a View commit details
    Browse the repository at this point in the history

  3. add /dev to gitignore

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1b0232d View commit details
    Browse the repository at this point in the history

  4. add some special cases for AbstractZero in Jnew

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    dd34364 View commit details
    Browse the repository at this point in the history

  5. convert the AbstractZero to nothing just before the API

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    8d690d7 View commit details
    Browse the repository at this point in the history

  6. single deprecation message

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    8c9df06 View commit details
    Browse the repository at this point in the history

  7. Jnew nothing -> Zero() 

    Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
    @mzgubic @oxinabox
    mzgubic and oxinabox authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    ef63558 View commit details
    Browse the repository at this point in the history

  8. update the deprecation warning

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c625e45 View commit details
    Browse the repository at this point in the history

  9. Jnew return DoesNotExist()

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    215bb1e View commit details
    Browse the repository at this point in the history

  10. actually hold your horses on this one

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a1339e6 View commit details
    Browse the repository at this point in the history

  11. switch to using wrap_chainrules_output

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    14fd86d View commit details
    Browse the repository at this point in the history

  12. update the warning

    Miha Zgubic committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    b52f171 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. change the I adjoint to switch to Zero()

    Miha Zgubic committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    d0b1ee5 View commit details
    Browse the repository at this point in the history

  2. revert back to replacezero, wrap_chainrules_output fulfills a differe… 

    …nt purpose
    Miha Zgubic committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    f4ce810 View commit details
    Browse the repository at this point in the history

  3. fix replacezero

    Miha Zgubic committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    d063e54 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. chain rules output stays Zero()

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    372da2b View commit details
    Browse the repository at this point in the history

  2. modify the tuple_va to trim Zero() as well

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    737299b View commit details
    Browse the repository at this point in the history

  3. add special case for literal getindex

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    9a292fd View commit details
    Browse the repository at this point in the history

  4. add warning counter to tests

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    b2a7925 View commit details
    Browse the repository at this point in the history

  5. change accum to Zero(), has no effect

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    8dcfb5c View commit details
    Browse the repository at this point in the history

  6. change the @Nograd macro

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    ca3a1c7 View commit details
    Browse the repository at this point in the history

  7. lib/lib.jl changes

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    4e48b2e View commit details
    Browse the repository at this point in the history

  8. more lib/lib.jl changes

    Miha Zgubic committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    ad46c9f View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. fix accum bug

    Miha Zgubic committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    33e6082 View commit details
    Browse the repository at this point in the history

  2. change accum :nothing to Zero()

    Miha Zgubic committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    4c23669 View commit details
    Browse the repository at this point in the history

  3. *squashes a chonky boi*

    Miha Zgubic committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    e3df2fa View commit details
    Browse the repository at this point in the history

  4. Update src/compiler/interface2.jl 

    Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
    @mzgubic @oxinabox
    mzgubic and oxinabox authored Sep 16, 2020
    Configuration menu
    Copy the full SHA
    53baaf2 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Lyndon White <oxinabox@ucc.asn.au>
    @mzgubic @oxinabox
    mzgubic and oxinabox authored Sep 16, 2020
    Configuration menu
    Copy the full SHA
    4935974 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2020

  1. combine tests

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    5239105 View commit details
    Browse the repository at this point in the history

  2. use the ZygoteRules zeros2nothings

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    ebe8a11 View commit details
    Browse the repository at this point in the history

  3. gradindex Nothing to DoesNotExist()

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    6716807 View commit details
    Browse the repository at this point in the history

  4. keep nothings in adjoints

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    a10b124 View commit details
    Browse the repository at this point in the history

  5. undo the test/Project.toml changes

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    912f5ae View commit details
    Browse the repository at this point in the history

  6. do not change the adjoint return via nt_nothing

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    3701e48 View commit details
    Browse the repository at this point in the history

  7. delete whitespace

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    bd48fab View commit details
    Browse the repository at this point in the history

  8. change back to nothing in apply adjoint

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    3e5c907 View commit details
    Browse the repository at this point in the history

  9. add comment

    Miha Zgubic committed Sep 18, 2020
    Configuration menu
    Copy the full SHA
    2b06b39 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. move constructor to Zero()

    Miha Zgubic committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    75bf62b View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. rename function to anticipate composite

    Miha Zgubic committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    0a2c50b View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. rename to differential2legacy

    Miha Zgubic committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    b5742cc View commit details
    Browse the repository at this point in the history

  2. change some custom pullbacks

    Miha Zgubic committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    230104a View commit details
    Browse the repository at this point in the history

  3. error in ZBack rather than warn

    Miha Zgubic committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    d56d680 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. differential2legacy at gradmap

    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    5741375 View commit details
    Browse the repository at this point in the history

  2. add errors to places where nothing should not 

    be received
    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    b2b624a View commit details
    Browse the repository at this point in the history

  3. change runadjoint to wrap differential

    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    6ebb581 View commit details
    Browse the repository at this point in the history

  4. rename legacytype_error

    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    ec21205 View commit details
    Browse the repository at this point in the history

  5. fix a minor mistake

    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    a04a6d3 View commit details
    Browse the repository at this point in the history

  6. revert Jnew to use legacy types

    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    0c12fd9 View commit details
    Browse the repository at this point in the history

  7. accum should use legacy types as it is used in 

    adjoint macro
    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    21096b7 View commit details
    Browse the repository at this point in the history

  8. comment on a line

    Miha Zgubic committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    dff733f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. rewrite the __new__ @adjoint as a custom pullback

    Miha Zgubic committed Oct 5, 2020
    Configuration menu
    Copy the full SHA
    3e6ae66 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2020

  1. fix the warning coming from sum

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    ba4a1ba View commit details
    Browse the repository at this point in the history

  2. fix the broken logic in Jnew

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    a97b376 View commit details
    Browse the repository at this point in the history

  3. make things right in the world of side effects

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    fb113a1 View commit details
    Browse the repository at this point in the history

  4. add an additional test for prod (similar to sum)

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    91f7f27 View commit details
    Browse the repository at this point in the history

  5. rename the warning

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    48c0996 View commit details
    Browse the repository at this point in the history

  6. make ZBack warning the same as the others

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    9412ab1 View commit details
    Browse the repository at this point in the history

  7. fix warn

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    7851a35 View commit details
    Browse the repository at this point in the history

  8. clean up

    Miha Zgubic committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    2b118d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. get rid of the differentialtype_warn coming from broadcast

    Miha Zgubic committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    44438a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. rearrange the code a bit

    Miha Zgubic committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    d10d5df View commit details
    Browse the repository at this point in the history

  2. using ZygoteRules (not import)

    Miha Zgubic committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    7c9dc60 View commit details
    Browse the repository at this point in the history

  3. clean up some comments

    Miha Zgubic committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    38e0380 View commit details
    Browse the repository at this point in the history