Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test from #705 #729

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Add test from #705 #729

merged 1 commit into from
Jul 10, 2020

Conversation

mcabbott
Copy link
Member

@mcabbott mcabbott commented Jul 8, 2020

Closes #705

Test failure on 1.3 is "ERROR: Unsatisfiable requirements detected for package CUDA [052768ef]".

@DhairyaLGandhi
Copy link
Member

Thanks! This would need us to not test on 1.3

bors r+

bors bot added a commit that referenced this pull request Jul 9, 2020
729: Add test from #705 r=DhairyaLGandhi a=mcabbott

Closes #705

Test failure on 1.3 is "ERROR: Unsatisfiable requirements detected for package CUDA [052768ef]".

Co-authored-by: Michael Abbott <me@escbook>
@bors
Copy link
Contributor

bors bot commented Jul 9, 2020

Build failed:

@DhairyaLGandhi
Copy link
Member

Ah I misremwbered bumping the Julia version in GitLab CI. Would you mind bumping that quickly?

@mcabbott
Copy link
Member Author

mcabbott commented Jul 9, 2020

Wait what needs changing? I can't see the bors logs.

If you want to drop support for 1.3 entirely, then I think this PR isn't the place.

@DhairyaLGandhi
Copy link
Member

CUDA 1.1 dropped support for julia 1.3, which is why the errors come up. Just want to make sure our CI is updated/ bound to the right CUDA version, so we can either make it run with CUDA 1.0 or test on Julia 1.4

@mcabbott
Copy link
Member Author

mcabbott commented Jul 9, 2020

OK, that makes some sense. Although not entirely sure why Pkg fails to download the last compatible version, if the constraint is Julia. Anyway no great rush here.

@CarloLucibello
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 10, 2020

Build succeeded:

@bors bors bot merged commit 0cb277c into FluxML:master Jul 10, 2020
@mcabbott mcabbott deleted the complextest branch July 10, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect complex gradients, Zygote 0.4.21
3 participants