Add test from #705 #729
Merged
Add test from #705 #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This would need us to not test on 1.3 bors r+ |
|
Build failed: |
|
Ah I misremwbered bumping the Julia version in GitLab CI. Would you mind bumping that quickly? |
|
Wait what needs changing? I can't see the bors logs. If you want to drop support for 1.3 entirely, then I think this PR isn't the place. |
|
CUDA 1.1 dropped support for julia 1.3, which is why the errors come up. Just want to make sure our CI is updated/ bound to the right CUDA version, so we can either make it run with CUDA 1.0 or test on Julia 1.4 |
|
OK, that makes some sense. Although not entirely sure why |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #705
Test failure on 1.3 is "ERROR: Unsatisfiable requirements detected for package CUDA [052768ef]".