Skip to content

Tag for SpecialFunctions@2 #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Tag for SpecialFunctions@2 #1138

merged 1 commit into from
Dec 22, 2021

Conversation

DhairyaLGandhi
Copy link
Member

Ref #1137

@devmotion
Copy link
Collaborator

The test error (https://github.com/FluxML/Zygote.jl/runs/4554123422?check_suite_focus=true#step:6:178) is caused by CUDA, it appears in multiple other packages as well (e.g. DiffRules and ChainRules). The problem is that an ancient version of CUDA is pulled in since the newer releases are not compatible with SpecialFunctions 2 (this does not affect the installation of Zygote since it is only installed and loaded in the tests). The upcoming release of CUDA will support SpecialFunctions 2 which should resolve this problem.

@DhairyaLGandhi
Copy link
Member Author

DhairyaLGandhi commented Dec 16, 2021

Right, I'm assuming CUDA is ready to be tagged? I saw that the version was bumped on master but hasn't been registered yet. We can register zygote with passing CI since it seems only registration of CUDA is the remaining piece for SpecialFunctions@2 which shouldn't hold us up too much and we can get a complete CI run although I think we should be fine with the new version too.

@devmotion
Copy link
Collaborator

CUDA 3.6.0 is available now, can you rerun the tests? Hopefully they should pass 🙂

@devmotion
Copy link
Collaborator

devmotion commented Dec 22, 2021

Tests pass (apart from buildkite which wasn't restarted) 🎉

@devmotion
Copy link
Collaborator

Good to go? Buildkite passed as well now 🙂

@DhairyaLGandhi
Copy link
Member Author

Yes, I'd wanted to get ci passing, thanks for bumping!

@DhairyaLGandhi DhairyaLGandhi merged commit 3a23a34 into master Dec 22, 2021
@DhairyaLGandhi DhairyaLGandhi deleted the DhairyaLGandhi-patch-1 branch December 22, 2021 15:05
@DhairyaLGandhi DhairyaLGandhi restored the DhairyaLGandhi-patch-1 branch December 22, 2021 15:05
@DhairyaLGandhi DhairyaLGandhi deleted the DhairyaLGandhi-patch-1 branch December 22, 2021 15:05
@devmotion
Copy link
Collaborator

devmotion commented Dec 22, 2021

Thanks, can you register the new release? Or do you want to wait until tests pass on the master branch as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants