Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Base.ismutabletype #1003

Merged
merged 3 commits into from
Jun 21, 2021
Merged

use Base.ismutabletype #1003

merged 3 commits into from
Jun 21, 2021

Conversation

mcabbott
Copy link
Member

May fix a test failure on master.

src/lib/lib.jl Outdated Show resolved Hide resolved
Co-authored-by: Johnny Chen <johnnychen94@hotmail.com>
@CarloLucibello CarloLucibello merged commit 9759239 into FluxML:master Jun 21, 2021
@mcabbott mcabbott deleted the ismutabletype branch June 21, 2021 16:49
if VERSION > v"1.7.0-DEV.204"
using Base: ismutabletype
else
function ismutabletype(@nospecialize(t::Type))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pure this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's copied straight from Base, I see this was discussed here: https://github.com/JuliaLang/julia/pull/39037/files#r550261314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants