-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error with BitVector #1086
Comments
Try with an older version of zygote. |
bors bot
added a commit
that referenced
this issue
Oct 2, 2021
1089: Fix broadcasting `-` with booleans r=CarloLucibello a=mcabbott Closes #1086 The issue is that `unbroadcast` collapses the gradient of a non-differentiable argument to `nothing`, Zygote's marker for such things, which the rule then tried to negate. (This is why CRC defines its own zero types for this purpose, instead of using nothing). I presume the original reason for `-unbroadcast(y, Δ)` not `unbroadcast(y, -Δ)` is to save an allocation when `y` is a scalar etc. I did not see any other cases where further operations are done after `unbroadcast`. Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
bors bot
added a commit
that referenced
this issue
Oct 2, 2021
1089: Fix broadcasting `-` with booleans r=mcabbott a=mcabbott Closes #1086 The issue is that `unbroadcast` collapses the gradient of a non-differentiable argument to `nothing`, Zygote's marker for such things, which the rule then tried to negate. (This is why CRC defines its own zero types for this purpose, instead of using nothing). I presume the original reason for `-unbroadcast(y, Δ)` not `unbroadcast(y, -Δ)` is to save an allocation when `y` is a scalar etc. I did not see any other cases where further operations are done after `unbroadcast`. Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Without the
-
it works:The text was updated successfully, but these errors were encountered: