Fix direct Depthwise convolution implementation #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a silly typo bug in the direct depthwise convolution algorithm that broke multi-channel testsets. Perhaps more disturbingly, our default test set did not catch this, because multi-channel workloads are not run unless the fuzzing tests are run.
CarloLucibello
approved these changes
Dec 4, 2021
|
Thanks for catching this @staticfloat , maybe we should have an optional GHA action for fuzzing tests. It lgtm, let me know if you're happy and we can merge this. |
Co-authored-by: Carlo Lucibello <carlo.lucibello@unibocconi.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a silly typo bug in the direct depthwise convolution algorithm
that broke multi-channel testsets. Perhaps more disturbingly, our
default test set did not catch this, because multi-channel workloads are
not run unless the fuzzing tests are run.