add groups to DenseConvDims (w/o implementation of grouped conv) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dhairya Gandhi <dhairya@juliacomputing.com>
|
Unsure why this is done, the groups PR got the reviews it needed and is ready to merge too. |
because it has been in the work for 4 months, and since this is an outstanding missing feature we have I wanted to speed up things, e.g. work on the CUDA side of this, but having the support for froups in DenseConvDims is a necessary condition. If #289 is nearly fineshed I'm totally happy, just didn't look complete nor actively worked |
|
It got the review I had wanted just yesterday (late night my time too), and have been actively maintaining it. It's done otherwise as you can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out this small change from #289 to accelerate things.
After this PR, we can proceed with cudnn integration (FluxML/NNlibCUDA.jl#9)