-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
missing adjoints for pooling functions with specified graph size #147
Comments
Thank you for pointing this out. The pooling function here is not sound. |
Thanks. That sounds great. I also just want to comment on the performance of scatter operations. Not sure if it is helpful. Because the adjoint of computational example:
But if we use
Does this mean that there is more room to improve efficiency? |
@wwang2 Current status is updated in yuehhua/ScatterNNlib.jl#32. |
@yuehhua awesome, thanks for the nice contribution. I will surely use it for my work. |
@wwang2 All APIs for |
The adjoint is not implemented for pooling function with custom
c
as inputs. For this case, Zygote produces nothing for the gradient.Usually, we don't specify
c
, but It will be an issue if the last node in the array is disconnected: specifyingc
makes sure the dimensions are consistent.example:
proposed fix:
I wonder if adding the following would fix it?
The text was updated successfully, but these errors were encountered: