Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Makie.jl instead of AbstractPlotting.jl #55

Conversation

terasakisatoshi
Copy link
Contributor

Hi, FluxML members!

Since using AbstractPlotting.jl is deprecated, this PR adopts Makie.jl instead of AbstractPlotting.jl for visualization of 3D data.

As a minor change, this commit 5644608 drops GeometryBasics 0.2 and 0.3 because these versions are too old for current Makie.

After this PR is merged, we can use Flux3D.visualize function as below:

if isdefined(Main, :IJulia)
    @eval using WGLMakie
else
    @eval using GLMakie
end

using Flux3D

dataset_dir = "~/dataset/pointcloud/modelnet" |> expanduser

dset = ModelNet10(root = dataset_dir, train = true)

visualize(dset[100])

From IJulia

image

From Julia REPL

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2022

Codecov Report

Merging #55 (5644608) into master (0d2d663) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #55   +/-   ##
=======================================
  Coverage   85.30%   85.30%           
=======================================
  Files          21       21           
  Lines        1014     1014           
=======================================
  Hits          865      865           
  Misses        149      149           
Impacted Files Coverage Δ
src/Flux3D.jl 60.00% <ø> (ø)
src/visualize.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2d663...5644608. Read the comment docs.

@nirmal-suthar
Copy link
Contributor

Thanks @terasakisatoshi

@nirmal-suthar nirmal-suthar merged commit 6cf7bc7 into FluxML:master Jan 10, 2022
@terasakisatoshi terasakisatoshi deleted the use-Makie-instead-of-AbstractPlotting branch January 11, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants