-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproducible Benchmarks #10
Conversation
bump |
I am also changing the format of PointCloud to 3xNxB, so this benchmark need to be updated. I will make necessary changes to the benchmark once I finish this change. |
ccb111c
to
202277a
Compare
@avik-pal I have added kaolin equivalent script for benchmark, can you please review it. |
LGTM. Can you run the benchmarks and report the results here before it goes in? |
(Kaolin) Results of NormalizePointCloud on gpu is looking a bit odd
|
How are you running the benchmarks? |
on cyclops |
(Flux3D) Updated
|
Cyclops can be a bit noisy, but more than that, use |
Also please add graphs for these numbers to the readme. |
dab45c3
to
d93fac1
Compare
d93fac1
to
9547ede
Compare
The horizontal plot is definitely the one we should go with |
I am thinking to add TriMesh benchmarks and graph in this PR before merging. Will rebase this once TriMesh PR is merged. |
Maybe let's merge this PR before the TriMesh. We might want to do performance regressions in the benchmark PR for Meshes. Also, don't forget to add the plots in the README |
Sure |
@nirmal-suthar You missed adding the plot to README |
I have updated readme on master, missed it here. |
Fixes #13
TODOs: