[WIP] Decaydocs #954
Merged
[WIP] Decaydocs #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 9, 2019
954: [WIP] Decaydocs r=MikeInnes a=baggepinnen I found the docstring to leave a lot for the imagination regarding the workings of the decays optimizers. It's still unclear to me why we need to provide a step size to `ExpDecay` when there is a step size in the wrapped optimizer. Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
Timed out |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 9, 2019
680: Added new loss functions. r=thebhatman a=thebhatman I have added the KL Divergence Loss function, Poisson loss function, Logcosh loss, and Hinge loss function. 954: [WIP] Decaydocs r=dhairyagandhi96 a=baggepinnen I found the docstring to leave a lot for the imagination regarding the workings of the decays optimizers. It's still unclear to me why we need to provide a step size to `ExpDecay` when there is a step size in the wrapped optimizer. Co-authored-by: Manjunath Bhat <manjunathbhat9920@gmail.com> Co-authored-by: thebhatman <manjunathbhat9920@gmail.com> Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
Timed out (retrying...) |
bors bot
added a commit
that referenced
this pull request
Dec 10, 2019
954: [WIP] Decaydocs r=dhairyagandhi96 a=baggepinnen I found the docstring to leave a lot for the imagination regarding the workings of the decays optimizers. It's still unclear to me why we need to provide a step size to `ExpDecay` when there is a step size in the wrapped optimizer. Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
|
Thanks for the fixes! |
Timed out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the docstring to leave a lot for the imagination regarding the workings of the decays optimizers. It's still unclear to me why we need to provide a step size to
ExpDecaywhen there is a step size in the wrapped optimizer.