compat, pkg up #946
Merged
compat, pkg up #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 28, 2019
946: compat, pkg up r=MikeInnes a=MikeInnes Needed to finalise the release process. We still have a dependency on CuArrays master here. Usually we'd try to get on release branches, but we know CuArrays is solid apart from an annoying CUDNN bug that is a problem for our CI. So I think we can keep it here and release a patch for CuArrays later. cc @dhairyagandhi96 Co-authored-by: Mike Innes <mike.j.innes@gmail.com>
| AbstractTrees = "0.2" | ||
| Adapt = "1" | ||
| CodecZlib = "0.5, 0.6" | ||
| Colors = "0.8, 0.9" | ||
| CuArrays = "1.4.3" |
There was a problem hiding this comment.
Shouldn't CuArrays be bumped too?
There was a problem hiding this comment.
Given how rare the RNN issue is, I think we should just let the resolver install 1.4.3 if it really needs to, rather than erroring out. Of course in most cases it should just install the most recent version anyway.
Timed out |
Closed
|
CI is flaky again, but tested locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to finalise the release process.
We still have a dependency on CuArrays master here. Usually we'd try to get on release branches, but we know CuArrays is solid apart from an annoying CUDNN bug that is a problem for our CI. So I think we can keep it here and release a patch for CuArrays later.
cc @dhairyagandhi96