Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binarycrossentropy on CuArrays #926

Merged
merged 2 commits into from
Nov 15, 2019
Merged

Fix binarycrossentropy on CuArrays #926

merged 2 commits into from
Nov 15, 2019

Conversation

janEbert
Copy link
Contributor

@janEbert janEbert commented Nov 8, 2019

Ref #889.

@MikeInnes
Copy link
Member

Thanks @janEbert!

bors r+

bors bot added a commit that referenced this pull request Nov 8, 2019
@bors @janEbert
Merge #926
4f42fb2 
926: Fix binarycrossentropy on CuArrays r=MikeInnes a=janEbert

Ref #889.

Co-authored-by: janEbert <janpublicebert@posteo.net>
@MikeInnes
Copy link
Member

Would you mind following up with a quick test also?

@janEbert
Copy link
Contributor Author

janEbert commented Nov 8, 2019

Oh sure, sorry that I forgot about that!

@bors
Copy link
Contributor

bors bot commented Nov 8, 2019

Canceled

@janEbert
Copy link
Contributor Author

janEbert commented Nov 8, 2019

Added it.

@MikeInnes
Copy link
Member

Wonderful, thanks again.

bors r+

bors bot added a commit that referenced this pull request Nov 8, 2019
@bors @janEbert
Merge #926
d43ea71 
926: Fix binarycrossentropy on CuArrays r=MikeInnes a=janEbert

Ref #889.

Co-authored-by: janEbert <janpublicebert@posteo.net>
@bors
Copy link
Contributor

bors bot commented Nov 8, 2019

Build failed

@MikeInnes
Copy link
Member

Getting scuppered by #923. If the error on 1.0 is also present on master, we can just merge this anyway.

@MikeInnes MikeInnes merged commit 9d6f6fd into FluxML:master Nov 15, 2019
@matsueushi matsueushi mentioned this pull request Nov 22, 2019
Merged
bors bot added a commit that referenced this pull request Nov 26, 2019
@bors @matsueushi
Merge #940
7c181fd 
940: Fix logitbinarycrossentropy on CuArrays r=MikeInnes a=matsueushi

The issue of logitbinarycrossentropy on GPU #464 can be also fixed by @janEbert's approach #926.

Co-authored-by: matsueushi <matsueushi@gmail.com>
@xukai92 xukai92 mentioned this pull request Feb 18, 2020
Closed
@janEbert janEbert deleted the bc-cuda-fix branch April 4, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janEbert @MikeInnes