modifications to support proximal optimization #778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f::Function | ||
| end | ||
|
|
||
| shrink(α) = f(z) = z > α ? α : z < -α ? -α : z |
There was a problem hiding this comment.
Passing a closure to the forward pass can be simplified since we already have alpha. Might be worth just making it into a normal function and combining it in the update rule?
|
L1 and L2 norm clipping landed in #1133, so this can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of my tests, using proximal optimization for regularization functions (like L1 and L2 norms) has been quite efficient,