Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance normalization #634

Merged
merged 4 commits into from
Mar 7, 2019
Merged

instance normalization #634

merged 4 commits into from
Mar 7, 2019

Conversation

dhpollack
Copy link

While playing with Flux, I implemented Instance Normalization, which is popular in style transfer. I've copied the functionality of batch norm. Thought I'd submit a pull request in case you were interested in adding it to the library.

Copy link
Contributor

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Looks reasonable to me, and it fits in well with the BatchNorm example. I'm happy to include this.

test/layers/normalisation.jl Outdated Show resolved Hide resolved
src/layers/normalise.jl Outdated Show resolved Hide resolved
@dhpollack dhpollack mentioned this pull request Mar 6, 2019
src/layers/normalise.jl Outdated Show resolved Hide resolved
@MikeInnes
Copy link
Member

@staticfloat are you happy with the changes? Needs a quick update for recent changes but otherwise GPU tests pass and I think we're good to go.

@staticfloat
Copy link
Contributor

LGTM! Thanks @dhpollack!

@staticfloat staticfloat merged commit 82578bf into FluxML:master Mar 7, 2019
@MikeInnes
Copy link
Member

Thanks @dhpollack and @staticfloat!

@dhpollack I just added a new NEWS.md, new policy is that you have to show off your work there :) Can you add an entry to it?

@dhpollack dhpollack deleted the instancenorm branch March 10, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants