Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not install all GPU backends at once #2453

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Do not install all GPU backends at once #2453

merged 2 commits into from
Jun 15, 2024

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Jun 4, 2024

  • Do not install all GPU backends at once. Install them only when actually testing. Helps prevent issues seen in CI here: Bump AMDGPU to 0.9 #2449
  • Add separate text/Project.toml file.

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable

mcabbott
mcabbott approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems broadly fine, merge once tests pass on CI?

@pxl-th
Copy link
Member Author

pxl-th commented Jun 5, 2024

@mcabbott CUDA.jl passes tests, Metal.jl fails due to unrelated reasons (needs LLVM.jl bump) and AMDGPU CI is temporarily offline

@pxl-th
Copy link
Member Author

pxl-th commented Jun 7, 2024 •
edited
Loading

@mcabbott, AMDGPU CI now processed through as well. Can we merge, if everything else is OK? And if possible tag a new release (I don't have write rights)

@mcabbott mcabbott merged commit 4d674a9 into FluxML:master Jun 15, 2024
5 of 8 checks passed
@mcabbott
Copy link
Member

Sorry about delays.

I merged this & tried to tag, but the robot complains about bounds on JSON: JuliaRegistries/General#109085 (comment)

@pxl-th pxl-th deleted the pxl-th/test-project branch June 15, 2024 20:52
@CarloLucibello CarloLucibello mentioned this pull request Jun 17, 2024
Merged
@cncastillo cncastillo mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pxl-th @mcabbott