Skip to content

Don't import Losses in Flux namespace #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Don't import Losses in Flux namespace #1928

wants to merge 1 commit into from

Conversation

CarloLucibello
Copy link
Member

No description provided.

@ToucheSir
Copy link
Member

Does anything outside of the tests need updating?

@CarloLucibello
Copy link
Member Author

I changed my mind on this, Flux.mse and others are used in many docs, doing this now would be too breaking. Maybe also there is really no need for it (I just think it makes more clear to the user where definitions live)

@CarloLucibello CarloLucibello mentioned this pull request Apr 6, 2022
Open
@mcabbott
Copy link
Member

mcabbott commented Apr 6, 2022

One downside of the module, btw, is that they don't autocomplete: Flux.ms <tab> shows nothing.

@CarloLucibello CarloLucibello deleted the CarloLucibello-patch-5 branch April 7, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarloLucibello @ToucheSir @mcabbott