Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news for bump version #1838

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Add news for bump version #1838

merged 2 commits into from
Jan 27, 2022

Conversation

DhairyaLGandhi
Copy link
Member

@DhairyaLGandhi DhairyaLGandhi commented Jan 16, 2022

Adds some missing NEWS items and prepares for patch bump.

I don't think we are breaking any API in this version, and if we want to include some PRs to this patch, it might be good to get some feedback on what we might want to include here.

@DhairyaLGandhi
Copy link
Member Author

Needs #1840

@cossio
Copy link
Contributor

cossio commented Jan 26, 2022

This is ready now?

NEWS.md Outdated Show resolved Hide resolved
Co-authored-by: cossio <cossio@users.noreply.github.com>
@darsnack
Copy link
Member

darsnack commented Jan 27, 2022

I think this is good to go, but it would be nice to get #1849 in too. It should be done assuming tests clear. Can we merge this and I can rebase+merge #1849 before releasing?

@cossio
Copy link
Contributor

cossio commented Jan 27, 2022

@darsnack What's the problem with doing #1849 in a separate patch release? Both are non-breaking so it should be okay to just do one release and then another in case #1849 takes longer.

@darsnack
Copy link
Member

No problem, just trying to avoid two patches in quick succession. But I really thought #1849 test would pass this time...let's just go ahead and release without it.

@cossio
Copy link
Contributor

cossio commented Jan 27, 2022

two patches in quick succession

I think there is nothing wrong with this. Could even be good. Quoting [1]

TL;DR; Every Pull Request should increment the version number in the Project.toml, and then you should register the release immediately after merging. Why do this? Because people are making PRs to your repo because they want that change. Don’t make them wait for you to tag a release. Also for all the normal advantages of continuous delivery.

(I'm waiting for some of the PRs already merged :) )

[1] https://www.oxinabox.net/2019/09/28/Continuous-Delivery-For-Julia-Packages.html.

@darsnack darsnack merged commit ef04fda into FluxML:master Jan 27, 2022
@cossio
Copy link
Contributor

cossio commented Jan 27, 2022

Can we tag a release?

@darsnack
Copy link
Member

Yes, I am just waiting on the CI to turn green (I know there's no logical reason it shouldn't, but it helps to be paranoid when releasing something to users).

@cossio
Copy link
Contributor

cossio commented Jan 27, 2022

You mean the green checkmark on the main repo page? I think it's already green.

@darsnack
Copy link
Member

Yeah, I just triggered the release

@cossio
Copy link
Contributor

cossio commented Jan 27, 2022

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants