Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trilinear Upsample layer #1792

Merged
merged 3 commits into from
Nov 30, 2021
Merged

Add trilinear Upsample layer #1792

merged 3 commits into from
Nov 30, 2021

Conversation

tknopp
Copy link
Contributor

@tknopp tknopp commented Nov 29, 2021

The trilinear Upsample layer was missing although it was actually already implemented in NNLib. This PR makes it accessible through the Upsample layer.

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable
  • API changes require approval from a committer (different from the author, if applicable)

ToucheSir
ToucheSir previously approved these changes Nov 29, 2021
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tknopp
Copy link
Contributor Author

tknopp commented Nov 30, 2021

I added a news entry and checked all the marks. Not sure if I should do this or a reviewer should do it.

@ToucheSir
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 30, 2021

Build succeeded:

@bors bors bot merged commit 6d0e123 into FluxML:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants