Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup and fix of multiplication by OneHotMatrix #1756

Merged
merged 22 commits into from
Oct 28, 2021
Merged

Speedup and fix of multiplication by OneHotMatrix #1756

merged 22 commits into from
Oct 28, 2021

Commits on Oct 25, 2021

  1. adding commented out sparse optimizations

    @racinmat
    racinmat committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    da9fbba View commit details
    Browse the repository at this point in the history

  2. Speedup of multiplication by OneHotMatrix. 

    Also fixed gradient calculation on GPU.
    @racinmat
    racinmat committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    9427363 View commit details
    Browse the repository at this point in the history

  3. return benchs

    @racinmat
    racinmat committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a1f35a2 View commit details
    Browse the repository at this point in the history

  4. removing benchmark which should be in different repo

    @racinmat
    racinmat committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    6d0468e View commit details
    Browse the repository at this point in the history

  5. removed unrelated code, fixed typo, fixed NEWS entry.

    @racinmat
    racinmat committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    5c31069 View commit details
    Browse the repository at this point in the history

  6. defining special method in order to keep reshaped arrays untouched

    @racinmat
    racinmat committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    60d2516 View commit details
    Browse the repository at this point in the history

  7. Update test/onehot.jl 

    Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
    @racinmat @ToucheSir
    racinmat and ToucheSir authored Oct 25, 2021
    Configuration menu
    Copy the full SHA
    6e79d64 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. Update test/cuda/cuda.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @racinmat @CarloLucibello
    racinmat and CarloLucibello authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7268c89 View commit details
    Browse the repository at this point in the history

  2. Update src/onehot.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @racinmat @CarloLucibello
    racinmat and CarloLucibello authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5f7ce6b View commit details
    Browse the repository at this point in the history

  3. Update test/cuda/cuda.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @racinmat @CarloLucibello
    racinmat and CarloLucibello authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    931d409 View commit details
    Browse the repository at this point in the history

  4. adding optimization of multiplication by adjoint

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    2507126 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/racinmat/Flux.jl

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    644bd1a View commit details
    Browse the repository at this point in the history

  6. fixed dimension check, added tests to check different dimensionality

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    5ac7a3d View commit details
    Browse the repository at this point in the history

  7. Update src/onehot.jl 

    Co-authored-by: Carlo Lucibello <carlo.lucibello@gmail.com>
    @racinmat @CarloLucibello
    racinmat and CarloLucibello authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    75f0e9c View commit details
    Browse the repository at this point in the history

  8. using gather for OneHotLike

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7ce132f View commit details
    Browse the repository at this point in the history

  9. Update src/onehot.jl 

    Co-authored-by: Brian Chen <ToucheSir@users.noreply.github.com>
    @racinmat @ToucheSir
    racinmat and ToucheSir authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    f221ee9 View commit details
    Browse the repository at this point in the history

  10. using different method for onehot vector and onehot matrix

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    0a67472 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' of https://github.com/racinmat/Flux.jl

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    fcda965 View commit details
    Browse the repository at this point in the history

  12. returning to default implementation for onehot because I don't want t… 

    …o break it.
    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    6e2da25 View commit details
    Browse the repository at this point in the history

  13. dispatching on OneHotLike of dimension 2

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    775efee View commit details
    Browse the repository at this point in the history

  14. added many tests for reshaped matrices

    @racinmat
    racinmat committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    51b7c00 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. fixed tests, using only onehot for adjoint

    @racinmat
    racinmat committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    35ab120 View commit details
    Browse the repository at this point in the history