Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag patch version #1721

Merged
merged 1 commit into from
Sep 29, 2021
Merged

tag patch version #1721

merged 1 commit into from
Sep 29, 2021

Conversation

CarloLucibello
Copy link
Member

No description provided.

@DhairyaLGandhi
Copy link
Member

We want to get #1708 in before releasing.

@CarloLucibello
Copy link
Member Author

CarloLucibello commented Sep 25, 2021

I gave a review to #1708. It seems to have a few regressions and it's not even clear what it is fixing or what is the added value. So probably we don't want to have that as a release blocker (especially for a patch version). Bumping version again when it is ready is not a big deal in any case.

@DhairyaLGandhi
Copy link
Member

Master returns different types that are non breaking but reverting them would be breaking. I've added more context to #1078

In the meanwhile, if there's something specific needed from master, I'm happy to do a cherrypicked release.

@CarloLucibello
Copy link
Member Author

Master returns different types that are non breaking but reverting them would be breaking.

What are these different types? If you refer to the changes due to ProjectTo, those are in Zygote and have already been tagged.

If you refer to something #1704 (which is precisely the PR I need) I don't see what we would be reverting in a breaking way

@CarloLucibello
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

Build succeeded:

@bors bors bot merged commit 2804618 into master Sep 29, 2021
@CarloLucibello CarloLucibello deleted the CarloLucibello-patch-3 branch April 7, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants