[DO NOT MERGE] Check works with CRC 1.0 #1679
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hopefully the nightly fails are due to nightlies being nightly. |
Member
Author
|
yes nightly has been broken on Zygote for a while now |
Member
|
Not on Flux though. I think this is a language issue and not a package issue, so I'm sure it will stabilise soon enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test to make sure everything works with the new release of ChainRulesCore.
I have added custom branchs of NNLib and Zygote and ComponentArrays to the Manifest so we can see how things go
FluxML/Zygote.jl#1035
FluxML/NNlib.jl#338
SciML/ComponentArrays.jl#102
Once we are done looking at CI we can close this PR