Add AbstractOptimiser type #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick Q: is this a precursor to integrating Optimisers.jl or an unrelated change? |
|
For the PR, I'm seeing it as an orthogonal utility. It will come in handy with the functional optimisers too, since we can define some methods on abstract types now. |
|
Bump? You're making us do bad things 😆 https://github.com/SciML/GalacticOptim.jl/pull/135/files#diff-540e217120afa5df2f98a3967f3f310bcae228d239cea1c8d3f1f2ef2065254eR1 |
|
So I take it you're in favour :p ? |
|
Let's merge this and see where we want to go with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an abstract type over all of Flux's optimisers, which serves to disambiguate an optimiser defined by Flux when there are multiple optimisation libraries being used together. Does this need news?
PR Checklist
@dhairyagandhi96(for API changes).