Optimistic ADAM #1246
Merged
Optimistic ADAM #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are sure about the implementation? it seems different from the one in the paper |
|
actually I was wrong, the implementation is correct |
CarloLucibello
approved these changes
Jun 30, 2020
|
Thanks! bors r+ |
|
pff, this news thing produces a lot of conflicts the merging PRs one after another |
|
Merge conflict. |
|
should I do a rebase or something? |
|
Yes, rebase please
Il mar 30 giu 2020, 20:23 cossio <notifications@github.com> ha scritto:
… should I do a rebase or something?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1246 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVQOQSQ424CWFSQPDDAKGDRZIUQLANCNFSM4OE3F3TQ>
.
|
added 4 commits
June 30, 2020 22:52
|
Rebased |
|
Is the CI fail on Julia 1 important? Doesn't look related to this PR. |
|
the failure is on the current stable version but it's unrelated to this pr (is a doctest fail) bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimistic ADAM is a variant of ADAM which adds an "optimistic" term, suitable for adversarial training of a model. The optimistic term can be interpreted as predicting the gradient of the adversary.
Reference: https://par.nsf.gov/biblio/10079723-training-gans-optimism
PR Checklist
@MikeInnesor@dhairyagandhi96(for API changes).