Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Flux.skip() #1232

Merged
merged 4 commits into from
Oct 9, 2020
Merged

add Flux.skip() #1232

merged 4 commits into from
Oct 9, 2020

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Jun 16, 2020 •
edited
Loading

per #821

PR Checklist

  • Tests are added
  • Entry in NEWS.md
  • Documentation, if applicable
  • Final review from @MikeInnes or @dhairyagandhi96 (for API changes).

@DhairyaLGandhi
Copy link
Member

Can we add tests in here please?

@DhairyaLGandhi
Copy link
Member

bump

@Moelf
Copy link
Contributor Author

Moelf commented Aug 20, 2020

added

@Moelf
Copy link
Contributor Author

Moelf commented Oct 8, 2020

@DhairyaLGandhi bump

@DhairyaLGandhi
Copy link
Member

Thanks for the bump, this is really close. One nit, could we have the test skip for a particular value of i? That way it's easier to determine what the skip is intended for

@DhairyaLGandhi
Copy link
Member

Nice, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 9, 2020

Build succeeded:

@bors bors bot merged commit 9ed04bb into FluxML:master Oct 9, 2020
@atiyo atiyo mentioned this pull request Aug 31, 2021
Open
@mcabbott mcabbott mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moelf @DhairyaLGandhi