Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in documents #1706

Closed
rongcuid opened this issue Sep 7, 2021 · 1 comment · Fixed by #1707
Closed

Typos in documents #1706

rongcuid opened this issue Sep 7, 2021 · 1 comment · Fixed by #1707

Comments

@rongcuid
Copy link
Contributor

rongcuid commented Sep 7, 2021

In the Overview documentation, there is an error that causes execution to fail if followed verbatim:

julia> parameters = params(predict) # <-- Must qualify as Flux.params
Params([[-0.99009055], [0.0]])
@DhairyaLGandhi
Copy link
Member

Good eye! Would you want to send in a quick PR?

@rongcuid rongcuid mentioned this issue Sep 7, 2021
Merged
2 tasks
bors bot added a commit that referenced this issue Sep 7, 2021
@bors @rongcuid
Merge #1707
d6002ca 
1707: Fix #1706 r=DhairyaLGandhi a=rongcuid

Added qualification for `params` in docs

Fixes #1706 

### PR Checklist

- [ ] Entry in NEWS.md
- [X] Documentation, if applicable


Co-authored-by: Rongcui Dong <rongcuid@users.noreply.github.com>
@bors bors bot closed this as completed in 9a395b2 Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #1706 rongcuid/Flux.jl
2 participants
@rongcuid @DhairyaLGandhi