FIX: prevent navigation block when device time is adjusted backward #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where Modular’s navigation system could prevent page transitions if the device's date/time was adjusted backward.
Context
In some systems, the device’s date and time can be automatically synchronized via an NTP server, an API endpoint, or external hardware. If the device clock was ahead and then corrected to an earlier time, the time difference calculation (
currentTime.difference(_lastClick)
) would result in a negative value. Since the original code blocked navigation when this difference was less than 500ms, this could permanently prevent navigation.Solution
Now, the time difference calculation ensures it never goes negative:
If
currentTime
is earlier than_lastClick
, the difference is considered 0, allowing navigation to proceed as expected.Breaking Change