fix: change builder name to flutter_gen_runner (#589) #592
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #592 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 24 24
Lines 905 907 +2
=======================================
+ Hits 887 889 +2
Misses 18 18 ☔ View full report in Codecov by Sentry. |
|
Could we compatible with both names? |
I will try. |
AlexV525
approved these changes
Oct 20, 2024
|
Thanks for the fix @b2nkuu and for merging it @AlexV525! One small thing: the test in the (merged) fix contains a typo, "runnfer" should be "runner" in line 233 of asset_gen_test.dart: const build = 'test_resources/build_runnfer_assets.yaml';
~~~~~~~ |
AlexV525
added a commit
that referenced
this pull request
Oct 22, 2024
## What does this change? - Addresses #592 (comment) - Make logs prettier ## Type of change - [x] Bug fix (non-breaking change which fixes an issue)
Merged
AlexV525
added a commit
that referenced
this pull request
Feb 5, 2025
## 5.9.0 **Feature** - [#587](#587) Support Lottie ZIP archive files. by [@AlexV525](https://github.com/AlexV525) - [#599](#599) Use `FilterQuality.medium` for the image integration. by [@AlexV525](https://github.com/AlexV525) - [#615](#615) Support `dart_style` v3. by [@AlexV525](https://github.com/AlexV525) - [#618](#618) Remove Flare integration. by [@AlexV525](https://github.com/AlexV525) - [#619](#619) Generate package path for directory. by [@AlexV525](https://github.com/AlexV525) - [#620](#620) Format Dart files with the current Dart version instead of the latest supported. by [@AlexV525](https://github.com/AlexV525) - [#621](#621) Adds `.lottie` support. by [@AlexV525](https://github.com/AlexV525) - [#635](#635) Support `archive` v4. by [@AlexV525](https://github.com/AlexV525) - [#645](#645) Allows not enable the image integration. by [@AlexV525](https://github.com/AlexV525) **Development** - [#593](#593) Better stdouts. by [@AlexV525](https://github.com/AlexV525) - [#622](#622) Fix invalid codecov config. by [@AlexV525](https://github.com/AlexV525) - [#630](#630) Update proper EOF. by [@AlexV525](https://github.com/AlexV525) - [#643](#643) Improvements with code lints. by [@AlexV525](https://github.com/AlexV525) - [#644](#644) Format code. by [@AlexV525](https://github.com/AlexV525) **Bug fix** - [#592](#592) Accept both `flutter_gen` and `flutter_gen_runner` as the entry of build.yaml. by [@b2nkuu](https://github.com/b2nkuu)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #589 🎯
change builder name to flutter_gen_runner
Type of change
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test)melos run formatto automatically apply formatting)