Use dialog from shared UI #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graypaper-reader ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughReplaced local dropdown-menu module; migrated modal UI from react-modal to shared-ui DialogModal and removed react-modal; updated Tailwind imports and added shared-ui styles; swapped several HTML buttons for Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Header
participant MoreBtn as MoreNotesActionsButton
participant Settings as SettingsModal
participant Dialog as DialogModal(shared-ui)
User->>Header: clicks "More"
Header->>MoreBtn: open modal
MoreBtn->>Settings: set isOpen = true
Settings->>Dialog: Dialog.open = isOpen
Dialog-->>Settings: user clicks Close
Settings->>MoreBtn: onClose -> toggleModal
MoreBtn->>Header: isOpen = false (modal closed)
rect #F0F7FF
note right of Dialog: DialogModal replaces react-modal and local modal implementation
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (20)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Visual Regression Test Report ✅ PassedGithub run id: 18317522940 🔗 Artifacts: Download |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
53-53: Drop the orphaned@types/react-modalentry.Since we no longer ship
react-modal, the corresponding type package now just bloats installs. Please remove it to keep devDependencies aligned with actual usage.- "@types/react-modal": "^3.16.3",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: visual-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Style
Chores
Refactor
Chores
Infrastructure