TASK: Update FrontendNodeRoutePartHandler to current "original"

[kdambekalns]

The FrontendNodeRoutePartHandler lacked quite some changes from the implementation in Neos, and thus

• did not resolve shortcuts directly to their target
• did not know about the nodeType options

Also the exception codes have been "uniqueified".

[kitsunet]

Added a bunch of Exception use statements as Exception\SomethingException wouldn't resolve in here.

[kdambekalns]

Added a bunch of Exception use statements as Exception\SomethingException wouldn't resolve in here.

There is use Neos\Neos\Routing\Exception; at the top… so it worked. With your change, I do get warnings in PhpStorm now about NoSiteNodeException not existing. 😎

[kitsunet]

but Neos\Neos\Routing\Exception is a class itself? And \Neos\Neos\Routing\Exception\NoSiteNodeException exists for me?

[kdambekalns]

but Neos\Neos\Routing\Exception is a class itself? And \Neos\Neos\Routing\Exception\NoSiteNodeException exists for me?

Yes, with use Neos\Neos\Routing\Exception in your code you can use

• Exception to refer to Neos\Neos\Routing\Exception
• Exception\NoSiteNodeException to refer to Neos\Neos\Routing\Exception\NoSiteNodeException

That's why it worked.

But you changed Exception\NoSiteNodeException to NoSiteNodeException, and forgot to add use Neos\Neos\Routing\Exception\NoSiteNodeException that is then needed…

[kitsunet]

Ja! I was not exactly "zurechnungsfähig" anymore ^^ Although I always prefer separate use statements.