BUGFIX: TransliterateNodeName to allow setting properties on a childNode with invalid name #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
commented
Jun 12, 2023
…ode with invalid name A valid node name must match this expression /^[a-z0-9\-]+$/ But Neos is so kind to still allow invalid configuration, and it transliterates the string We must make sure that the same transliteration is applied to our childNode names to match the node names from the CR
mhsdesign
force-pushed
the
bugfix/transliterateNodeName
branch
from
b736201 to
b4394ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A valid node name must match this expression /^[a-z0-9-]+$/ But Neos is so kind to still allow invalid configuration, and it transliterates the string We must make sure that the same transliteration is applied to our childNode names to match the node names from the CR