BUGFIX: Position TemplateNodeCreationHandler to the end #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: this comment is outdated ;) Thanks, @mhsdesign (also for allowing static titles / uriPathSegments, that are not EEL expressions). Perhaps we could simplify some parts as we do not need to cover the default behaviour any more. I'll think about it... |
|
patch is released ^^ https://github.com/neos/neos-ui/releases/tag/8.3.1 |
this makes our hacky DelegatingDocumentTitleNodeCreationHandler obsolete
mhsdesign
force-pushed
the
bugfix/45-templatingDocumentTitleNodeCreationHandler
branch
from
323b8ea to
5794564
Compare
mhsdesign
changed the title
|
Do we need a min version of the Neos.Ui in our dependencies then? |
|
actually yes that would be the cleanest - ill fix that ^^ |
this patch level release https://discuss.neos.io/t/neos-ui-bugfix-releases-7-3-18-8-0-13-8-1-10-8-2-10-8-3-1/6351 contains this fix we need neos/neos-ui#3511
mhsdesign
deleted the
bugfix/45-templatingDocumentTitleNodeCreationHandler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also we dont replace the original one anymore
closes #45
BLOCKED BY neos/neos-ui#3511