Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Parse EEL Expressions in "type" #38

Merged
merged 3 commits into from
May 27, 2023

Conversation

mhsdesign
Copy link
Contributor

Currently the field type does not allow eel expressions:

childNodes:
  product-details:
    type: "${data.isSpecial ? 'My.Site:NodeType' : 'My.Site:NodeType.Special'}"
    properties:
       foo: bar

It might seem to be an odd usecase, as the property overlap of two different nodeTypes might not be that high. Nevertheless i have a usecase for it and want it, and dont think we necessarily need to restrict it to simple strings only.

Co-authored-by: Thomas Heilmann <1016315+theilm@users.noreply.github.com>
@theilm theilm merged commit 48589d9 into master May 27, 2023
@mhsdesign mhsdesign deleted the bugfix/eelExpressionInNodeType branch May 27, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants