BUGFIX: sanitize current page input#52
Merged
dlubitz merged 1 commit intoFlowpack:3.6from Aug 18, 2025
Merged
Conversation
dlubitz
reviewed
Aug 18, 2025
Contributor
dlubitz
left a comment
There was a problem hiding this comment.
Thank you for taking care. I left a question, as I couldn't test it myself atm.
dlubitz
approved these changes
Aug 18, 2025
Contributor
dlubitz
left a comment
There was a problem hiding this comment.
Ok, I tested it quickly and it works as expected.
# this is also 1
currentPage = ${0 || 1}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On paginated sites the
currentPageis not sanitized result in thrown errors:Unsupported operand types: string * int.You can see this in the wild as soon as paginated page urls get manipulated. Samples:
We see these errors frequently in logs and exceptions from bots trying to exploit this.