Skip to content

BUGFIX: Drop FilterByReferenceOperation#51

Merged
kdambekalns merged 1 commit intomainfrom
bugfix/drop-reference-filter
Jul 3, 2025
Merged

BUGFIX: Drop FilterByReferenceOperation#51
kdambekalns merged 1 commit intomainfrom
bugfix/drop-reference-filter

Conversation

@kdambekalns
Copy link
Member

This is broken (references are no longer properties) and can be solved way easier, e.g.

collection = ${q(node).backReferenceNodes('tags')}

instead of

collection = ${q(site).find('[instanceof Acme.Com:Document.Post]').filterByReference('tags', node).get()}

This is broken (references are no longer properties) and can be solved
way easier, e.g.

    collection = ${q(node).backReferenceNodes('tags')}

instead of

    collection = ${q(site).find('[instanceof Acme.Com:Document.Post]').filterByReference('tags', node).get()}
@kdambekalns kdambekalns requested a review from dlubitz June 26, 2025 09:40
@kdambekalns kdambekalns self-assigned this Jun 26, 2025
@kdambekalns
Copy link
Member Author

  • We could do it like that.
  • Or keep the operation, but make it syntactic sugar to help the users out there.
  • Should this be a breaking change, given it's broken without the change, too?

😎

Copy link
Contributor

@dlubitz dlubitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with removal in this case.

@kdambekalns kdambekalns merged commit ea01fe0 into main Jul 3, 2025
@kdambekalns kdambekalns deleted the bugfix/drop-reference-filter branch July 3, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants