Skip to content

Add workspaceId in options if not already there.#5503

Merged
HenryHengZJ merged 3 commits intoFlowiseAI:mainfrom
mskitroot:bugfix/issue5477-workspaceIdMissing
Nov 22, 2025
Merged

Add workspaceId in options if not already there.#5503
HenryHengZJ merged 3 commits intoFlowiseAI:mainfrom
mskitroot:bugfix/issue5477-workspaceIdMissing

Conversation

@mskitroot
Copy link
Contributor

@mskitroot mskitroot commented Nov 20, 2025

Bugfix for issue.

WorkspaceId is needed for variable interpolation but it's not part of the options object. The fix adds it if not there.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mskitroot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the workspaceId was not always included in the options object when performing variable interpolation. The fix ensures that workspaceId is correctly propagated to the getVars function, which is crucial for proper variable resolution within the system. This change improves the robustness of variable handling, particularly in scenarios involving custom MCP configurations.

Highlights

  • Bugfix for WorkspaceId: Resolved an issue where workspaceId was not consistently available within the options object for variable interpolation, leading to potential failures in getVars.
  • WorkspaceId Injection: Ensured that the workspaceId is explicitly added to the options object passed to the getVars function if it's not already present, preventing variable interpolation issues.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where workspaceId was missing for variable interpolation. The fix correctly ensures workspaceId is included in the options object passed to getVars. The logic is sound. I have one suggestion to improve a comment for better code clarity and maintainability.

mskitroot and others added 2 commits November 21, 2025 13:47
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@HenryHengZJ HenryHengZJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@HenryHengZJ HenryHengZJ linked an issue Nov 22, 2025 that may be closed by this pull request
@HenryHengZJ HenryHengZJ merged commit b5f7fac into FlowiseAI:main Nov 22, 2025
2 checks passed
davehamptonusa pushed a commit to davehamptonusa/Flowise that referenced this pull request Nov 24, 2025
* Add workspaceId in options if not already there.

* Update packages/components/nodes/tools/MCP/CustomMCP/CustomMCP.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
davehamptonusa pushed a commit to davehamptonusa/Flowise that referenced this pull request Dec 8, 2025
* Add workspaceId in options if not already there.

* Update packages/components/nodes/tools/MCP/CustomMCP/CustomMCP.ts

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpolating variable in the Custom MCP config

2 participants