fix: correct aria-posinset values

[javier-godoy]

Close #45

Summary by CodeRabbit

• Accessibility Improvements
  • Improved slider dot accessibility by ensuring aria-posinset and aria-label attributes use 1-based numbering, enhancing compatibility with assistive technologies.
  • Internal handling of slide positions remains consistent for smoother navigation and interaction.

[coderabbitai]

Walkthrough

The code modifies how the aria-posinset attribute is handled in the paper slider component to ensure it uses 1-based indexing for accessibility, while internal logic continues to use 0-based indexing. Adjustments include template bindings, event handlers, and the addition of a helper method for consistent value transformation.

Changes

File(s)	Change Summary
src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js	Updated aria-posinset attribute to be 1-based in template; adjusted event handlers to convert to 0-based; updated aria-label logic; added private _increment helper method.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Ensure aria-posinset values start at 1 (#45)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js (1)

662-664: LGTM: Helper method correctly implemented with minor formatting suggestion.

The _increment helper method correctly converts 0-based indexing to 1-based for accessibility purposes. The implementation is clean and serves its purpose well.

Consider adding a space around the + operator for consistency:

-      return n+1;
+      return n + 1;

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f105525 and 1bf143f.

📒 Files selected for processing (1)

• src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js (5 hunks)

🔇 Additional comments (5)

src/main/resources/META-INF/resources/frontend/paper-slider/l2t-paper-slider.js (5)

183-183: LGTM: Correct aria-posinset implementation for accessibility.

The change to use _increment(item) ensures that aria-posinset uses 1-based indexing as required by ARIA specifications, while maintaining 0-based indexing internally.

---

464-464: LGTM: Correct conversion from 1-based aria-posinset to 0-based position.

The subtraction of 1 correctly converts the 1-based aria-posinset value back to 0-based indexing for internal position tracking.

---

482-482: LGTM: Consistent use of 1-based aria-posinset in aria-label.

The change correctly uses the 1-based aria-posinset value directly in the aria-label, removing the need for manual increment since the value is already 1-based.

---

484-484: LGTM: Correct conversion for click handler.

The subtraction of 1 correctly converts the 1-based aria-posinset to 0-based indexing for the movePos method call.

---

550-550: LGTM: Correct conversion for keyboard navigation.

The subtraction of 1 correctly converts the 1-based aria-posinset to 0-based indexing for keyboard navigation, maintaining consistency with the click handlers.

[paodb]

LGTM